search

sachinchoolur / lightGallery

A customizable, modular, responsive, lightbox gallery plugin.
https://www.lightgalleryjs.com/
Other
6.55k stars 1.29k forks source link

Account for "t" YouTube video start time GET variable, not just "start" #1610

Closed ItsFrankieD closed 2 months ago

ItsFrankieD commented 8 months ago

Summary

Include the standard t start time GET variable in the gallery when included on a YouTube video URL.

Basic example

Standard URL

https://youtube.com/watch?v=dQw4w9WgXcQ&t=90

Short URL

https://youtu.be/dQw4w9WgXcQ?t=90

No-cookie URL

https://youtube-nocookie.com/embed/dQw4w9WgXcQ?t=90&rel=0

Motivation

The t start time GET variable is very commonly used in embeds, and is not being passed to the gallery unless first being changed from t to start.

Previously, the GET variable was split between the current format, 90, which uses seconds, and the old format, 1m30s, which used minutes and seconds separately.

As an aside, no-cookie URLs do not pass the rel=0 GET variable. This raises privacy concerns, and is probably deserving of its own issue.

ItsFrankieD commented 7 months ago

Pardon, but is this project's issue queue active? I don't see much movement. Is there somewhere else I should be place my feature request?

stale[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ItsFrankieD commented 4 months ago

In that case, ping.

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ItsFrankieD commented 2 months ago

Well, this is getting a little silly now. I suppose it's time to move on to a new library.