sachinchoolur / lightGallery

A customizable, modular, responsive, lightbox gallery plugin.
https://www.lightgalleryjs.com/
Other
6.55k stars 1.29k forks source link

Carousel gallery transition errors #1643

Closed trouba closed 2 months ago

trouba commented 5 months ago

Description

Errors when interacting with the picture before it's loaded on the gallery carousel

Steps to reproduce

Can be reproduced on the demo page: https://www.lightgalleryjs.com/demos/carousel-gallery/

TypeError: undefined is not an object (evaluating '$image.getBoundingClientRect')
TypeError: undefined is not an object (evaluating '$image.get().getBoundingClientRect')
TypeError: undefined is not an object (evaluating '$image.get().offsetWidth')

It fires up a lot on mobile when switching through image if they are heavy and don't load quickly When using sentry, thousands of these errors appears in our logs

This is the same issue as this one https://github.com/sachinchoolur/lightGallery/issues/1485 but can easily be reproduced on the demos so I think it's worth investigating

trouba commented 4 months ago

It seems like these errors will be fixed in the 2.8.0, any news on when it will be out of beta @sachinchoolur ?

https://github.com/sachinchoolur/lightGallery/releases/tag/2.8.0-beta.2

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.