sachinchoolur / lightGallery

A customizable, modular, responsive, lightbox gallery plugin.
https://www.lightgalleryjs.com/
Other
6.55k stars 1.29k forks source link

SASS Warning About Future Changes #1647

Open jledgett opened 4 months ago

jledgett commented 4 months ago

When using the packing lightgallery's SCSS files into a project I now receive the following warning:

Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

    ╷
160 │ ┌         &:not(.lg-start-end-progress) {
161 │ │             background: url('#{$lg-path-images}/loading.gif') no-repeat scroll
162 │ │                 center center transparent;
163 │ │         }
    │ └─── nested rule
164 │           display: none !important;
    │           ^^^^^^^^^^^^^^^^^^^^^^^^ declaration
    ╵
    node_modules/lightgallery/scss/lightgallery-core.scss 164:9  @import
    node_modules/lightgallery/scss/lightgallery.scss 7:9         @import
    wwwroot/scss/site.scss 13:9                                  root stylesheet

Can you please resolve before deprecation occurs?

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

johanwilfer commented 2 months ago

This is also the case in v2, so the v1 tag here is incorrect? Can this be addressed?