sachinchoolur / lightGallery

A customizable, modular, responsive, lightbox gallery plugin.
https://www.lightgalleryjs.com/
Other
6.55k stars 1.29k forks source link

Fix SASS deprecation warning #1672

Open palicko opened 6 days ago

palicko commented 6 days ago

Hey, these small changes fix SASS deprecated warnings as mentioned in #1657 and #1647

Deprecation Warning on line 36, column 8 of
│ │ node_modules/lightgallery/scss/lg-autoplay.scss:36:8:
│ │ Sass's behavior for declarations that appear after nested
│ │ rules will be changing to match the behavior specified by CSS in an
│ │ upcoming
│ │ version. To keep the existing behavior, move the declaration above the
│ │ nested
│ │ rule. To opt into the new behavior, wrap the declaration in `& {}`.
│ │ More info: https://sass-lang.com/d/mixed-decls
│ │ 36 |         content: '/e01d';
│ │ node_modules/lightgallery/scss/lg-autoplay.scss 37:9          @import
│ │ node_modules/lightgallery/scss/lightgallery-bundle.scss 23:9  @import
│ │ resources/styles/lightgallery.scss 16:9                       root
│ │ stylesheet

and

│ │ Deprecation Warning on line 163, column 8 of
│ │ node_modules/lightgallery/scss/lightgallery-core.scss:163:8:
│ │ Sass's behavior for declarations that appear after nested
│ │ rules will be changing to match the behavior specified by CSS in an
│ │ upcoming
│ │ version. To keep the existing behavior, move the declaration above the
│ │ nested
│ │ rule. To opt into the new behavior, wrap the declaration in `& {}`.
│ │ More info: https://sass-lang.com/d/mixed-decls
│ │ 163 |         display: none !important;
│ │ node_modules/lightgallery/scss/lightgallery-core.scss 164:9   @import
│ │ node_modules/lightgallery/scss/lightgallery-bundle.scss 34:9  @import
│ │ resources/styles/lightgallery.scss 16:9                       root
│ │ stylesheet
CLAassistant commented 6 days ago

CLA assistant check
All committers have signed the CLA.