search

sachinchoolur / lightgallery.js

Full featured JavaScript image & video gallery. No dependencies
https://sachinchoolur.github.io/lightgallery.js/
Other
5.3k stars 596 forks source link

Request to add `aria-modal="true"` to modal div #110

Closed jitendersandhu closed 3 years ago

jitendersandhu commented 6 years ago

Hi @sachinchoolur,

We have been trying to make our website accessibility compliant (as per standards here) and in our effort to do that, we are adding aria-modal="true" to all the modals used in our website and lightgallery is one of them.

Could you please add the aria-modal="true" attribute to the .lg-outer div so that it can help us and everyone else, who is using this super awesome library, to make the web more accessible for users.

Suggestion: An option can be added accessible: true and if set, add aria-modal="true" to outer div inside the template here.

Please let us know if you want a PR for this feature request and thanks again for making such an awesome library!

Cheers, Jitender Singh

jitendersandhu commented 5 years ago

@sachinchoolur - Any updates on this please?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. If the issue is still valid for version 2.x, please re-open. Apologize for not responding on time. Thank you for your contributions.

jitendersandhu commented 3 years ago

@sachinchoolur - Any updates on this please?

sachinchoolur commented 3 years ago

Hey @jitendersandhu,

This has been fixed in version 2 - https://www.lightgalleryjs.com/ V2 is completely accessible.

Sorry for not responding on time