search

sachinchoolur / lightgallery.js

Full featured JavaScript image & video gallery. No dependencies
https://sachinchoolur.github.io/lightgallery.js/
Other
5.3k stars 596 forks source link

Fix typo #176

Closed bi-kim closed 3 years ago

DigitalZebra commented 4 years ago

Technically this would be a breaking change. There's a way to support the previously typo-ed parameter as well as support the fixed parameter. I think supporting both for the time being would be the way to go.

sachinchoolur commented 4 years ago

Yes, I had noticed this earlier, but since this is a breaking change, I thought I should update it in v2. But I think supporting both options is a good idea. @bi-kim would you be able to make the changes?

@DigitalZebra Thank you for the suggestion

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. If the issue is still valid for version 2.x, please re-open. Apologize for not responding on time. Thank you for your contributions.