search

sachinchoolur / lightgallery.js

Full featured JavaScript image & video gallery. No dependencies
https://sachinchoolur.github.io/lightgallery.js/
Other
5.3k stars 596 forks source link

util.js window & document getAttribute/setAttribute not working with google maps streetview #67

Closed philipp-winterle closed 5 years ago

philipp-winterle commented 7 years ago

Problem If you are using lightgallery.js with google maps on the same page (both libraries included) and want to use Google Maps Street View you will not be able to, because the lightgallery hardcoded functions for "getAttribute" and "setAttribute" on window and document will conflict with Google Maps Street View

Request Remove these functions from window and document and use a util function instead.

Pull Request already added to #68

4skinSkywalker commented 6 years ago

Same problem here. Please resolve

philipp-winterle commented 6 years ago

I guess the maintainer is not interested in PRs. Sadly

bio commented 6 years ago

I got the same issue. Please review PR.

sophielevens commented 5 years ago

Thanks for the solution @hummal.

Is there a reason that this hasn't been reviewed or merged? This is a blocker for us and we would really appreciate it, we are reliant on this plugin working alongside Google maps.

Thanks!

sachinchoolur commented 5 years ago

Guys, The issue has been fixed. Sorry for the delay. @hummal Thank you for the PR