search

sachinpc / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

Dump generator on Mac PPC leaves blank fields in MDRawSystemInfo #140

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The dump generator on the Mac
(src/client/mac/handler/minidump_generator.cc) doesn't fill in all of the
fields that it could/should.  processor_level and processor_revision, and
cpu are missing on x86.  We should also define processor_level (and perhaps
processor_revision) to have meaningful values for ppc, so that we can
distinguish between various PowerPC processors in a dump.

We do currently assume in some processor code that these values will be
properly populated for dumps that come from x86 CPUs.  For example, see the
minidump_stackwalk output at
http://google-breakpad.googlecode.com/svn/trunk/src/processor/testdata/minidump2
.stackwalk.out

Original issue reported on code.google.com by mmento...@gmail.com on 23 Mar 2007 at 6:01

GoogleCodeExporter commented 9 years ago 
Not to steal this from you, but here's a patch that calls cpuid on OS X Intel, 
and
fills in the appropriate fields.  I didn't touch the PPC side of things since I 
don't
have a PPC system, and that's going to require some definition of what things 
mean
anyway.

Original comment by ted.mielczarek on 10 May 2007 at 11:46

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by mmento...@gmail.com on 10 May 2007 at 8:13

GoogleCodeExporter commented 9 years ago 
Checked in with changes.  I don't know if you'd like to keep this open for 
defining
the PPC handling, or if you'd just rather open a new issue?

Original comment by ted.mielczarek on 11 May 2007 at 12:50

GoogleCodeExporter commented 9 years ago

Original comment by ted.mielczarek on 29 May 2007 at 12:41

GoogleCodeExporter commented 9 years ago

Original comment by ted.mielczarek on 29 May 2007 at 12:41