[Android Bootcamp] Review my app

[sachishah]

/cc @nesquena @timothy1ee

[nesquena]

:+1: Thanks Sachi, looks good overall a few points of feedback:

• Good layout, proper view naming, usage of sp/dp, margin and relative placement rules
• Good use of string resources for text values
• Source activity works fine, properly formatted and works as expected
• One strategy for click handling is to avoid having three different methods like "onTenPercent". Instead a common pattern in Android is to use android:tag which allow you to store metadata embedded in the view. Then you can use a single method for onClick for all three buttons and use the View v signature to differentiate the value based on id or tag. This is a way to reduce duplication and is a frequent pattern used for click handling.
• Glad you thought about error handling for empty input cases

Hopefully this has given you a first sense of the RelativeLayout which is a very powerful layout system, probably one of the best responsive-first layout systems available across web and mobile platforms. Let us know if you have any other thoughts or questions about the assignment.

The next assignment will build on top of the first concepts introduced here and will also introduce networking, api use, handling remote images and navigating between activities.