search

sachsmc / plotROC

Interactive ROC plots with ggplot + d3.js.
http://sachsmc.github.io/plotROC
Other
86 stars 15 forks source link

speeds up auc calculation #55

Closed rcorty closed 7 years ago

rcorty commented 7 years ago

as described in issue #54

solution is just to do the same calculation with dplyr rather than with a for loop

rcorty commented 7 years ago

@sachsmc Please accept or reject this PR -- I have another one incoming and I don't know how to have two open at the same time!

rcorty commented 7 years ago

damn -- guess I should have made a new branch to work on the cutoff.labels

rcorty commented 7 years ago

apologies -- there are now two suggested additions in one PR

sachsmc commented 7 years ago

I like the cutoff.labels parameter, but I am hesitant to add the huge dependency in dplyr just to calculate the AUC. It seems like overkill esp when I've seen people have installation and updating problems due to dplyr+Rcpp.

I ask you to remove that update, please. I don't think its worth it, especially since there are many ways to calculate the AUC in R, and that is somewhat tangential to plotting the ROC curve anyway.

sachsmc commented 7 years ago

I'm going to try to fix this using git cherry-pick so that your cutoff labels changes get merged, but not the calc_auc changes.