search

sacloud / terraform-provider-sakuracloud

Terraform provider for SakuraCloud
https://docs.usacloud.jp/terraform
Apache License 2.0
71 stars 23 forks source link

Fix error when updating server-connected disk #1128

Closed ak1ra24 closed 1 week ago

ak1ra24 commented 11 months ago

Reproduce:

When updating the size of a disk connected to the server, the timeout occurs when deleting the disk.

Solution

When updating the disk size, the disk will be deleted->created. So, if the server is connected to the disk when deleting, the disk will be deleted after shutdown -> disconnect from the server.

lvctr commented 11 months ago

Hi, thanks for the pull request! We'll check the commits at the beginning of next year.

atpons commented 1 week ago

Hello, I'm also waiting for review here. How's the situation?

yamamoto-febc commented 1 week ago

Sorry for the delay, I'll review it shortly.

yamamoto-febc commented 1 week ago

@ak1ra24 Thanks for the PR!

We require signed commits for all PRs. Could you sign the commit?

docs: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

ak1ra24 commented 1 week ago

Sorry, I missed it.

atpons commented 1 week ago

Thank you for review and contribution :)