search

sada-dream / sada-dream_server_v2

개인간 해외 직구 중계 플랫폼 사다드림입니다.
MIT License
0 stars 0 forks source link

feature_dev #65

Closed KIMHWANSEUNG closed 3 years ago

KIMHWANSEUNG commented 3 years ago

Slf4j 추가 JPA SEQ -> Idenetity

dongwooklee96 commented 3 years ago

Codecov Report

Merging #65 (301e056) into feature (136a203) will decrease coverage by 3.43%. The diff coverage is 37.50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             feature      #65      +/-   ##
=============================================
- Coverage      83.79%   80.36%   -3.44%     
- Complexity       114      120       +6     
=============================================
  Files             29       29              
  Lines            253      275      +22     
  Branches           4        4              
=============================================
+ Hits             212      221       +9     
- Misses            41       54      +13
Impacted Files Coverage Δ
.../main/java/com/sadadream/config/SwaggerConfig.java 0.00% <0.00%> (ø)
src/main/java/com/sadadream/domain/Product.java 100.00% <ø> (ø)
src/main/java/com/sadadream/App.java 71.42% <100.00%> (+4.76%) :arrow_up:
...m/sadadream/application/AuthenticationService.java 100.00% <100.00%> (ø)
...in/java/com/sadadream/application/UserService.java 100.00% <100.00%> (ø)
...a/com/sadadream/controllers/ProductController.java 100.00% <100.00%> (ø)
...a/com/sadadream/controllers/SessionController.java 100.00% <100.00%> (ø)
...java/com/sadadream/controllers/UserController.java 100.00% <100.00%> (ø)
src/main/java/com/sadadream/domain/User.java 78.94% <100.00%> (+1.16%) :arrow_up:
...n/java/com/sadadream/dto/UserRegistrationData.java 55.55% <0.00%> (+11.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5864838...301e056. Read the comment docs.

dongwooklee96 commented 3 years ago

@KIMHWANSEUNG 이전에 작성된 커밋이 딸려 들어오고 있습니다. 브랜치를 업데이트하고 다시 작업해주세요. 그리고 이번 수정건은 JPA 기본키 맵핑 방법을 수정한 것이므로, 관련된 커밋만 풀리퀘스트 해주세요, 로그와 관련된 것은 나중에 고려할 것 입니다.

dongwooklee96 commented 3 years ago

머지 커밋을 남기지 말아주세요, https://git-scm.com/book/ko/v2/Git-%EB%B8%8C%EB%9E%9C%EC%B9%98-Rebase-%ED%95%98%EA%B8%B0 리베이스를 이용하면, 머지 커밋이 남지 않습니다