sadanandpai / frontend-mini-challenges

Collection of frontend challenges for learning and interviews
https://sadanandpai.github.io/frontend-mini-challenges/
MIT License
2.02k stars 494 forks source link

fix(React/todo-list): todo items do not persist across page reloads. Fixes #185 #338

Closed proghax333 closed 10 months ago

proghax333 commented 10 months ago

fix(React/todo-list): todo items not being persisted across reloads. Fixes #185

Title : todo items not being persisted across reloads

Issue No. : #185

Code Stack : React

Close #185

Checklist:

Notes

netlify[bot] commented 10 months ago

Deploy Preview for preeminent-tapioca-4294b2 canceled.

Name Link
Latest commit 9b19fa9b0933d59d318e3d059ae341f14d02c176
Latest deploy log https://app.netlify.com/sites/preeminent-tapioca-4294b2/deploys/6554cba15f496c0009b92784
arpansaha13 commented 10 months ago

Oh now I see that you have added it as a tooltip. But still you may mention it in the UI

proghax333 commented 10 months ago

Oh now I see that you have added it as a tooltip. But still in case the user doesn't hover on it... you may mention it in the UI

text-decoration: line-through style is being added to completed todo tasks. The user can visually see a line striking through the todo's title.

Should something like (done) be shown to the user instead/with that?

arpansaha13 commented 10 months ago

Should something like (done) be shown to the user instead/with that?

No no, I meant that the user may not know bout the double-click functionality itself. I only got to know about the double-click functionality after going through the code. The line-through is fine.

proghax333 commented 10 months ago

No no, I meant that the user may not know bout the double-click functionality itself. I only got to know about the double-click functionality after going through the code.

I see. I'll mention it in the UI.

arpansaha13 commented 10 months ago

Thank you for your contribution!