search

sadanandpai / frontend-mini-challenges

Collection of frontend challenges for learning and interviews
https://sadanandpai.github.io/frontend-mini-challenges/
MIT License
1.96k stars 483 forks source link

2.0: Nx Monorepo setup #345

Closed sadanandpai closed 7 months ago

sadanandpai commented 7 months ago

Revamp of the repo with Nx monorepo and architectural changes for scalability and maintenance

POC: FMC: https://github.com/sadanandpai/fmc/ Web: https://sadanandpai.github.io/fmc/

Local testing: npm i npm run dev

netlify[bot] commented 7 months ago

Deploy Preview for preeminent-tapioca-4294b2 failed.

Name Link
Latest commit a8a0883d7c3e2a8e286f13a42d8ce3a893dc85b8
Latest deploy log https://app.netlify.com/sites/preeminent-tapioca-4294b2/deploys/656f1c373069c700087452b0
arpansaha13 commented 7 months ago

Which node version to use?

I am using v18 and I get error in dev script

image

sadanandpai commented 7 months ago

Tested fine on below node versions v20.9.0 v18.17.1

Support for Angular ANGULAR NODE.JS
17.0.x ^18.13.0 || ^20.9.0
netlify[bot] commented 7 months ago

Deploy Preview for candid-bienenstitch-0183c6 processing.

Name Link
Latest commit 8a08841c8c3fd989784e495e4b566eaaf46272a8
Latest deploy log https://app.netlify.com/sites/candid-bienenstitch-0183c6/deploys/65706e9cbd32ad0007576582
arpansaha13 commented 7 months ago

@sadanandpai please have a look if it is looking okie

sadanandpai commented 7 months ago

@arpansaha13 Updated deployment for final testing https://sadanandpai.github.io/fmc/

netlify[bot] commented 7 months ago

Deploy Preview for ubiquitous-beijinho-7964e4 ready!

Name Link
Latest commit c87f65eb45159dded21fb71d943dbc9690d4a854
Latest deploy log https://app.netlify.com/sites/ubiquitous-beijinho-7964e4/deploys/6571d5a380c7970008d6e33f
Deploy Preview https://deploy-preview-345--ubiquitous-beijinho-7964e4.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

arpansaha13 commented 7 months ago

Is the shared local packages approach okay? I had a feeling that the codebase is getting overcomplicated because of that What do u say?

sadanandpai commented 7 months ago

We will move to web components for common components soon using StencilJS. In that way shared components becomes simpler.

arpansaha13 commented 7 months ago

I see. I was thinking about web components too. VueJs provides this API to create custom elements. Stencil looks like pretty popular. I'll read the docs sometime then.