sadanandpai / frontend-mini-challenges

Collection of frontend challenges for learning and interviews
https://sadanandpai.github.io/frontend-mini-challenges/
MIT License
2.02k stars 494 forks source link

Create custom-elements with Stencil and use in JS app #348

Closed arpansaha13 closed 9 months ago

arpansaha13 commented 10 months ago

image

image

netlify[bot] commented 10 months ago

Deploy Preview for frontend-mini-challenges ready!

Name Link
Latest commit 28b25d7552794ab661768a3ad705487360109539
Latest deploy log https://app.netlify.com/sites/frontend-mini-challenges/deploys/657e7decf84f7d0008c46e60
Deploy Preview https://deploy-preview-348--frontend-mini-challenges.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sadanandpai commented 10 months ago

local dev is breaking with npm run dev. The dist has to be generated to make it work.

arpansaha13 commented 10 months ago

Oh yes the stencil build needs to happen. May be if we add that command in the script before running dev 🤔

arpansaha13 commented 10 months ago

This one will work if we run dev at the root. But if we run in individual workspace, then again the error will be there, if stencil is not already built.

sadanandpai commented 10 months ago
image
arpansaha13 commented 10 months ago
image

What to do here ?

sadanandpai commented 9 months ago

The netlify build is breaking with the changes. image

arpansaha13 commented 9 months ago

The "build-baseless" command was not made for stencil.

I tried doing it like the "build" command by adding "build-baseless" in stencil folder. But nx will run javascript and stencil build in parallel. So js build will fail again because stencil needs to build before js.

If we could configure nx so that it does not run js and stencil together, then this problem could be solve. But I couldn't find this in docs. So I edited the root scripts for now.

sadanandpai commented 9 months ago

image is this intentional

arpansaha13 commented 9 months ago

The back link or the design?

sadanandpai commented 9 months ago

yes

arpansaha13 commented 9 months ago

The design was intentional because some titles are very long resulting in overflow.

The back link is currently pointing to home page instead of challenge list page... this was not intentional... will fix

arpansaha13 commented 9 months ago

Mobile:

image

Desktop:

image