sadanandpai / frontend-mini-challenges

Collection of frontend challenges for learning and interviews
https://sadanandpai.github.io/frontend-mini-challenges/
MIT License
2.01k stars 493 forks source link

[React] Added Nested Comments Project #416

Closed Akshayone8 closed 5 months ago

Akshayone8 commented 7 months ago

Title and Issue number

Title : Nested Comments

Issue No. : #416

Code Stack : React

Close #

Screenshot 2024-03-03 at 11 26 52 AM

Checklist:

netlify[bot] commented 7 months ago

Deploy Preview for frontend-mini-challenges ready!

Name Link
Latest commit a52bdbe1027a67315546f7727b71767232f62e3c
Latest deploy log https://app.netlify.com/sites/frontend-mini-challenges/deploys/6622a71f5779bc0008241cb2
Deploy Preview https://deploy-preview-416--frontend-mini-challenges.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sadanandpai commented 7 months ago

@Akshayone8 can we also have reply & delete options

Akshayone8 commented 7 months ago

@sadanandpai Added reply and delete feature.

Screenshot 2024-03-04 at 6 10 59 PM
sadanandpai commented 7 months ago

There are conflicts. The comments reply is not working properly. Some comments after adding are not showing up but shows after cancel click

Akshayone8 commented 7 months ago

There are conflicts. The comments reply is not working properly. Some comments after adding are not showing up but shows after cancel click

@sadanandpai "Thank you for your patience. I've addressed the issue with the comments reply functionality and made the necessary changes. Please try using it again, and let me know if the problem persists or if you have any further feedback. Your input is valuable in ensuring a smooth user experience."

https://github.com/sadanandpai/frontend-mini-challenges/assets/62467248/5d398220-0264-45f9-a981-8818f6d59a05

Akshayone8 commented 7 months ago

Title : Navbar

Issue No. :

Code Stack : React

Close #

@sadanandpai Added new React challenge - Navbar

Screenshot 2024-03-05 at 9 20 13 AM Screenshot 2024-03-05 at 9 20 48 AM
sadanandpai commented 7 months ago

We can raise one PR for one task. Let's keep this only for Nested comments. Navbar can be taken separately. Else due to conflicts or bugs in one task other will be blocked

sadanandpai commented 7 months ago

@Akshayone8 conflicts

Akshayone8 commented 6 months ago

Hi @sadanandpai I have resolved the conflicts can u verify now.

sadanandpai commented 6 months ago

@Akshayone8 There is a major bug

https://github.com/sadanandpai/frontend-mini-challenges/assets/12962887/c1f40b6c-b2dc-4976-a288-c637466fecf8

Also can you plz make enter key to work after typing

arpansaha13 commented 5 months ago

A squash and merge could keep the commit history clean...