search

sadanandpai / frontend-mini-challenges

Collection of frontend challenges for learning and interviews
https://sadanandpai.github.io/frontend-mini-challenges/
MIT License
2.01k stars 493 forks source link

[WIP]feat/added dark-light theme and toggle button #418

Closed Dev-AkshatGupta closed 7 months ago

Dev-AkshatGupta commented 7 months ago

Title and Issue number

393 Add dark and light mode for the host application

Title: feat/ dark - light theme and toggle button

Issue No. : #393

Code Stack: Js, CSS

Close #<393>

Description:-

  1. Using Lucid for icons instead of Fontawesome found it better.
  2. Used Context for switching theme.
  3. Example in a video. https://github.com/sadanandpai/frontend-mini-challenges/assets/53713926/cf020e72-100f-404c-9d68-850d1c63468a
netlify[bot] commented 7 months ago

Deploy Preview for frontend-mini-challenges failed.

Name Link
Latest commit 4d560d7fbf12dc0ea8f414d2e356c8b67fa42212
Latest deploy log https://app.netlify.com/sites/frontend-mini-challenges/deploys/65e4b33539f91d00086752b4
sadanandpai commented 7 months ago

conflicts

sadanandpai commented 7 months ago

@Dev-AkshatGupta image

Dev-AkshatGupta commented 7 months ago

conflicts

@Dev-AkshatGupta image

Hey Sadanand I added WIP for the same I know why it's happening and rectified it locally. Just having some trouble with the git configuration I am figuring that out. Will sqash all commits in one. Thanks for reviewing.

Dev-AkshatGupta commented 7 months ago

Opened a new pr with conflicts solved and commits squashed https://github.com/sadanandpai/frontend-mini-challenges/pull/419