hammeiam commented 2 years ago

For some reason, the codebase had issues fetching information about the SLP pair, causing the TVL of the pair not to render. This was resolved by remove the reference to account from useSdlWethSushiPairContract. I removed it from a few other places as well for good housekeeping.

I also update the sushi link from the analytics page to https://ethereum.sushi.com/swap?inputCurrency=ETH&outputCurrency=0xf1Dc500FdE233A4055e25e5BbF516372BC4F6871

codecov[bot] commented 2 years ago

Codecov Report

Merging #1167 (2298764) into master (7791529) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1167   +/-   ##
=======================================
  Coverage   11.00%   11.00%           
=======================================
  Files         154      154           
  Lines        5659     5659           
  Branches     1792     1792           
=======================================
  Hits          623      623           
  Misses       5034     5034           
  Partials        2        2

Impacted Files	Coverage Δ
src/components/TopMenu.tsx	`0.00% <0.00%> (ø)`
src/hooks/useContract.ts	`3.82% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7791529...2298764. Read the comment docs.

arthur-zhuk commented 2 years ago

Why does removing reference to account solve the issue?

hammeiam commented 2 years ago

Why does removing reference to account solve the issue?

🤷‍♂️

saddle-finance / saddle-frontend

Fix SLP fetching issue #1167

Codecov Report