arthur-zhuk commented 2 years ago

Refactored POOLS_MAP out of Swap components. Tested swap successfully in hardhat enviornment.

Mostly renames and early returns after adjusting registryMigrationTokensMapRefactor

codecov[bot] commented 2 years ago

Codecov Report

Merging #1182 (bcd2372) into master (feead31) will decrease coverage by 0.01%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1182      +/-   ##
==========================================
- Coverage   10.53%   10.52%   -0.02%     
==========================================
  Files         157      157              
  Lines        5873     5879       +6     
  Branches     1877     1877              
==========================================
  Hits          619      619              
- Misses       5254     5260       +6

Impacted Files	Coverage Δ
src/hooks/useApproveAndSwap.ts	`0.00% <0.00%> (ø)`
src/hooks/useCalculateSwapPairs.ts	`60.71% <0.00%> (ø)`
src/hooks/useTokenMaps.ts	`0.00% <0.00%> (ø)`
src/pages/Swap.tsx	`0.00% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us.

hammeiam commented 2 years ago

@nguyenaiden please take a closer look at PRs, I think there's a lot of good feedback that could've been added in your review

saddle-finance / saddle-frontend

Registry migration swap refactor #1182

Codecov Report