arthur-zhuk commented 2 years ago

Removing tokens_map and dependencies of it.

branched off swap refactor. swap refactor should go first.

tested swapping locally.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1183 (6458ac8) into master (bf1ea69) will decrease coverage by 0.16%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1183      +/-   ##
==========================================
- Coverage   10.70%   10.53%   -0.17%     
==========================================
  Files         156      157       +1     
  Lines        5837     5873      +36     
  Branches     1859     1877      +18     
==========================================
- Hits          625      619       -6     
- Misses       5212     5254      +42

Impacted Files	Coverage Δ
src/components/PendingSwapExchange.tsx	`0.00% <0.00%> (ø)`
src/components/PendingSwapModal.tsx	`0.00% <0.00%> (ø)`
src/components/PendingSwapTimeline.tsx	`0.00% <0.00%> (ø)`
src/components/SwapPage.tsx	`0.00% <0.00%> (ø)`
src/constants/index.ts	`95.56% <ø> (ø)`
src/hooks/useApproveAndSwap.ts	`0.00% <0.00%> (ø)`
src/hooks/useCalculateSwapPairs.ts	`60.71% <0.00%> (ø)`
src/hooks/useContract.ts	`4.19% <ø> (+0.36%)`	:arrow_up:
src/hooks/usePendingSwapData.ts	`0.00% <0.00%> (ø)`
src/hooks/useTokenMaps.ts	`0.00% <0.00%> (ø)`
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

hammeiam commented 2 years ago

fyi you can specify your base branch. So if your branches are master -> A -> B, you can set your base to A instead of master and github will only display the diff between A and B. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request

saddle-finance / saddle-frontend

Registry migration tokens map refactor #1183

Codecov Report