saddle-finance / saddle-frontend

An open source UI for saddle.finance 🤠
https://saddle.exchange
54 stars 58 forks source link

Introduce Loadables and ExpandedPools #1193

Closed hammeiam closed 2 years ago

hammeiam commented 2 years ago

Loadables adhere to the type

export interface LoadableType<T> {
  isLoading: boolean
  isLoaded: boolean
  isError: boolean
  isSuccess: boolean
  error: Error | string | null
  data?: T
}

ExpandedPools are just like BasicPools except they are guaranteed to have all data about their tokens and underling tokens available

export type ExpandedPool = Omit<
  BasicPool,
  "tokens" | "underlyingTokens" | "lpToken"
> & {
  tokens: BasicToken[]
  underlyingTokens: BasicToken[]
  lpToken: BasicToken
}
codecov[bot] commented 2 years ago

Codecov Report

Merging #1193 (4c011bb) into master (2f8e583) will decrease coverage by 0.16%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1193      +/-   ##
==========================================
- Coverage   10.94%   10.77%   -0.17%     
==========================================
  Files         154      156       +2     
  Lines        5712     5800      +88     
  Branches     1799     1828      +29     
==========================================
  Hits          625      625              
- Misses       5087     5175      +88     
Impacted Files Coverage Δ
src/hooks/usePoolData.ts 0.00% <0.00%> (ø)
src/pages/App.tsx 0.00% <0.00%> (ø)
src/providers/ExpandedPoolsProvider.tsx 0.00% <0.00%> (ø)
src/utils/index.ts 39.75% <0.00%> (-6.01%) :arrow_down:
src/utils/loadable.tsx 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.