saddle-finance / saddle-frontend

An open source UI for saddle.finance 🤠
https://saddle.exchange
54 stars 58 forks source link

react-query initial bring in with respective upgrades #1195

Closed arthur-zhuk closed 2 years ago

arthur-zhuk commented 2 years ago

prerequisites for bringing in react-query are:

upgrade to the latest react-scripts ESLint is upgraded to v8 as its managed by react-scripts upgrade to the latest react + react-dom versions fix few types change initial render to adhere to the new React 18 approach metamaskIcon slight SVG syntax change removed gas property from a contract ABI that was problematic couple useQuery examples to start with

good-to-have follow-ups to be made for the following: react-router-dom or move onto tanstack's router to potentially solve any type ts issues that are currently ignored

image
codecov[bot] commented 2 years ago

Codecov Report

Merging #1195 (079bc6f) into master (51a1e90) will decrease coverage by 0.16%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1195      +/-   ##
==========================================
- Coverage   10.50%   10.33%   -0.17%     
==========================================
  Files         159      161       +2     
  Lines        5893     6035     +142     
  Branches     1881     1959      +78     
==========================================
+ Hits          619      624       +5     
- Misses       5274     5411     +137     
Impacted Files Coverage Δ
src/components/PoolOverview.tsx 0.00% <ø> (ø)
src/components/TopMenu.tsx 0.00% <ø> (ø)
src/components/WithdrawPage.tsx 0.00% <ø> (ø)
src/hooks/useApproveAndDeposit.ts 0.00% <0.00%> (ø)
src/hooks/useBasicTokens.ts 0.00% <0.00%> (ø)
src/hooks/useCalculateSwapPairs.ts 60.71% <0.00%> (ø)
src/hooks/useContract.ts 4.09% <ø> (-0.10%) :arrow_down:
src/hooks/useMulticallProvider.ts 0.00% <0.00%> (ø)
src/hooks/usePoolData.ts 0.00% <ø> (ø)
src/index.tsx 0.00% <0.00%> (ø)
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us.