saddle-finance / saddle-frontend

An open source UI for saddle.finance 🤠
https://saddle.exchange
54 stars 58 forks source link

Migrated and Meta Pool Withdraw Fix #1243

Closed arthur-zhuk closed 2 years ago

arthur-zhuk commented 2 years ago

Contract ABI selection was selecting the wrong ABI in the case the pool is migrated and a metapool.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1243 (588c3f4) into master (899d039) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1243      +/-   ##
==========================================
- Coverage   10.26%   10.26%   -0.01%     
==========================================
  Files         161      161              
  Lines        6088     6091       +3     
  Branches     2007     2009       +2     
==========================================
  Hits          625      625              
- Misses       5461     5464       +3     
  Partials        2        2              
Impacted Files Coverage Δ
src/utils/index.ts 36.22% <0.00%> (-0.44%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

arthur-zhuk commented 2 years ago

Did we verify this fixes the issue?

i verified it fixes the issue

arthur-zhuk commented 2 years ago

Is this PR redundant to #1247?

If yes, please close.

i dont have full context to that, david would be the better person to ask here.