saddle-finance / saddle-frontend

An open source UI for saddle.finance 🤠
https://saddle.exchange
54 stars 58 forks source link

TokenClaimDialog rewards patch #1307

Closed nguyenaiden closed 1 year ago

nguyenaiden commented 1 year ago

Description: In the case of when a user has SDL/Minter rewards for a gauge that previously has a non-Zero SDL rate and currently has a Zero rate value, the sdlReward does not get added to the gauge rewards attribute due to the Zero SDL rate check.

Solution: Removed the sdlRate check when concating the rewards lists and allow ClaimTokenDialog to handle showing/hiding gauge rewards depending on rewards balance rather than sdlRate

codecov[bot] commented 1 year ago

Codecov Report

Merging #1307 (cb73b21) into master (7497d8e) will increase coverage by 0.00%. The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master   #1307   +/-   ##
======================================
  Coverage    9.39%   9.39%           
======================================
  Files         182     182           
  Lines        6726    6725    -1     
  Branches     2164    2163    -1     
======================================
  Hits          632     632           
+ Misses       6094    6093    -1     
Impacted Files Coverage Δ
src/components/TokenClaimDialog.tsx 0.00% <ø> (ø)
src/utils/gauges.ts 0.55% <0.00%> (+<0.01%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more