sadesyllas / vscode-workspace-switcher

Easily switch between workspaces
GNU General Public License v3.0
28 stars 8 forks source link

Doesn't globs into subdirectory and Symbolic Link #19

Closed lamyergeier closed 5 years ago

lamyergeier commented 5 years ago

In my settings "vscodeWorkspaceSwitcher.paths": "/home/nikhil/Documents/Git/CS/**/*", does not finds the workspace files in the subdirectory. fast-glob supports this type of input.

lamyergeier commented 5 years ago

@sadesyllas I just noticed that most of my .code-workspace files are symbolic link. But the glob does not recognize them.

sadesyllas commented 5 years ago

Please, try v1.10.4 report whether this has been fixed or not.

lamyergeier commented 5 years ago

Hi it works. Somehow it is taking a lot of time. I have about 30 symlinked workspaces. Is it slow due to symlink?

sadesyllas commented 5 years ago

@anishmittal2020, to answer that I would need to know more about whether or not you have eg, cycles where one symlink points to another and things like that.

What do you mean by a lot of time?

sadesyllas commented 5 years ago

I am closing this as it's no longer relevant to the issue's topic.

Please, re-open it if you have more information or open another one describing what exactly goes wrong and an example setup where the extension is slow.

Thank you for your help catching this bug!