sadger / CorsixTH

Open source clone of Theme Hospital
Other
1 stars 0 forks source link

Advisor gives incorrect advise #19

Closed MarkL1961 closed 10 years ago

MarkL1961 commented 10 years ago

The advisor gives you a warning that you need to deal with the epidemic etc, but it is already cleared. There were only three people in this epidemic, one was cured before it was revealed, the second cured just as the epidemic fax arrived (there was an emergency in progress at the time). The third was quickly vaccinated and then cured.

Looking at the code it was most likely the hurry_up message, so perhaps include a count of how many patients are currently infected into the criteria for showing the message?

sadger commented 10 years ago

Currently it's when 1/4 of the time is remaining and no other condition, as the timer stays open even when everyone is cured. I did it like this to at be considered a general message but I guess I can add that at least one person who was infected is still not cured to the condition if you think it's better.

MarkL1961 commented 10 years ago

I think it would be better as we have had comments before about messages that are no longer relevant, so should not be seen.

sadger commented 10 years ago

Ok I'll add that in later it's just a small fix.

sadger commented 10 years ago

I have added and pushed this change so that the number infected is at least 1 when the hurry up message is given. Needs testing but should be pretty easy to verify.

MarkL1961 commented 10 years ago

That seems to be working :+1: