search

sadger / CorsixTH

Open source clone of Theme Hospital
Other
1 stars 0 forks source link

Vaccinating patient brings up patient dialog #23

Closed MarkL1961 closed 10 years ago

MarkL1961 commented 10 years ago

I have noticed that if you were to click on a patient whilst there is a cover up in progress it not only brings up the patient dialog it also marks them for vaccination.

I think it would be better if you could only vaccinate once you have clicked on the button above the watch first. Otherwise it can get annoying if you don't realise that is what you have done and were to try this method for vaccinations on others as the menu also comes up.

sadger commented 10 years ago

I think I prefer to leave it how it is, I think that's how the original worked too when I tried it. If people particularly complain we can change it. I think vaccination mode is how it is, if you want to click people without bringing any other dialog up etc.

MarkL1961 commented 10 years ago

In TH you can mark a patient for vaccination without clicking on the button first, but it does not bring up the patient dialog at the same time. It does though once you have marked them for vaccination first.

sadger commented 10 years ago

I'll change it so it does this then, shouldn't be too hard.

sadger commented 10 years ago

This should be fixed now, commit pushed. You can only bring up the dialog once you have already vaccinated someone, no dialogs will ever show in vaccination mode.

sadger commented 10 years ago

This is still broken you can't bring up certain dialogs when an epidemic is in progess but not discovered yet. I'll fix it tomorrow.

sadger commented 10 years ago

This is working as far as I can tell. Can someone please test it just to confirm. One more bug down for release (hopefully)

MarkL1961 commented 10 years ago

This is still happening, you click on a patient and you mark him for vaccination and it also brings up the patient menu.

sadger commented 10 years ago

This isn't happening for me, is it in vaccination mode or not? Are you using the epidemics branch now? Also can I have your save if you are so I can test it. You must make a new epidemic to test this I don't think existing ones will work.

MarkL1961 commented 10 years ago

I updated to the new branch yesterday, about 7.30ish. It is a new game. I was not using the vaccinating mode at the time. Perhaps you updated this after I downloaded the branch, we'll see tomorrow when I update again and start a new game.

sadger commented 10 years ago

I fixed it quite a while ago maybe it's an edge case. If you are still having the problem please can you give me an offending save tomorrow.

MarkL1961 commented 10 years ago

With the game I started yesterday this is now working as intended. I downloaded your branch again, but this time into a new folder, perhaps just updating on Friday missed a file. Any now another to cross of the list. :+1:

sadger commented 10 years ago

Great! I shall close this then. Just be aware that spawning a contagious patient on an old save might not work as intended. I'm trying to fix backwards compatibility currently.