sadger / CorsixTH

Open source clone of Theme Hospital
Other
1 stars 0 forks source link

Epidemic icons clear too soon #29

Closed MarkL1961 closed 10 years ago

MarkL1961 commented 10 years ago

I noticed that once the timer ends that most of the icons clear so you no longer know who is infected. The only icons that remained was the one with the arrow. This might be connected to another issue I have raised where the icon (same one) remained when the timer had gone. Either they should all clear or perhaps they should stay until the health inspector visits, it should not be possible to vaccinate anyone now, but I think you should still see who is infected so you can push them to the front of queues or send for the cure in the hopes you can beet the inspection. The count of who is still infected should happen once he is at reception (and I think it does), but if you are close to the cover up, you should still be able to see who.

sadger commented 10 years ago

Hmm.. I will look into this, thanks. They are probably related. I think clearing them all once the result is known makes sense, just need to make sure it happens at the right time.

sadger commented 10 years ago

Interesting now I look it it, because the timer ends you lose vaccination mode essentially but still should be able to vaccinate. You should be able to still keep vaccinating by clicking don't you think? So maybe all the icons should all stay until the inspector arrives like you say. We should only clear them all completely after the result has been determined like when someone leaves or the inspector gets to the desk. I'll get a fix for this done tomorrow. On a similar note if you vaccinate someone after the epidemic ends their icons will change, i'll fix this too if i can figure it out, basically just need to drop any vaccination calls.

sadger commented 10 years ago

We could keep the timer open and on 100% fully red, to indicate the inspector is coming and then only close it when he arrives so that they can use vacc-mode still until the very last minute? What do you think of that guys?

MarkL1961 commented 10 years ago

I don't think you should be able to vaccinate once the timer ends and it should stop spreading. You should however be able to see who is infected until the inspector arrives. So the watch should go or you could keep it until the inspector arrives, so long as you can't vaccinate anyone.

sadger commented 10 years ago

Oh ok, so change all infected patients back to the normal icon if they are marked or have the arrow. Or just leave them if they are vaccinated already. Then disable vaccination. I'll make this change soon and push it.

MarkL1961 commented 10 years ago

I think if you have marked them for vaccination that should be okay, nurses should be able to do the ones already marked before the timer ends so leave all icons as they were. If you have someone that has not been marked for vaccination your only option should be to push them to a cure fast. I am saying all this from memory and could do with checking TH again.

sadger commented 10 years ago

This should be fixed now, when the timer ends no new vaccinations can happen but any currently vaccinated or marked will keep their icons the same. Didn't realise I was so long gone from the issues, i'm trying to get a few sorted now we are nearly there.

sadger commented 10 years ago

The icons should appear and disappear at the right times now. If someone could confirm for me that would be great so I can close the issue.

MarkL1961 commented 10 years ago

This seems to be okay now :+1:

sadger commented 10 years ago

Awesome. I'll close it then. Thanks guys.