search

sadger / CorsixTH

Open source clone of Theme Hospital
Other
1 stars 0 forks source link

Hospital evac is including those that have not arrived! #34

Open MarkL1961 opened 10 years ago

MarkL1961 commented 10 years ago

epidemic_error Had an evacuation and noticed that it also included some patients that had not even arrived.

I think perhaps it should only include those that were in the hospital or going from one block to another and exclude anyone who has not even been at reception. From memory those in the reception queue in TH or had not arrived were not evacuated.

sadger commented 10 years ago

OK I have an idea how to fix this will have to wait until I get time to fix it now, work is getting busy this week. Thanks for reporting it.

MarkL1961 commented 10 years ago

I also noticed that my rep went down by about 440, I wonder whether there should be a maximum on this as for me this has killed this level (or would have done if I did not know how to fix the damage) Seriously, being evacuated is bad enough, losing that much rep in one go as well will make it impossible to get back above the lose threshold before the year end and I got fined. I think no more than 30% when combined with an evacuation is punishment enough.

sadger commented 10 years ago

It's a percentage of the total reputation equal to 1/3 33% of the total reputation. How about I amend it to 1/4 of the total reputation instead 25%?

MarkL1961 commented 10 years ago

If it is already 33% there is something wrong. Perhaps I also got stung with a load of sent homes at the same time as they have a rep loss? On the lua screen it was a fine of £25000 or there abouts and rep -441 I think

sadger commented 10 years ago

Maybe it's the sent homes that contribute too, i'll take another look at this and try and balance it.

MarkL1961 commented 10 years ago

Perhaps don't lose any rep on an evac as you will lose rep anyway from each one that is sent home; as they are -3 each. Then perhaps you could cap the loss of rep to 33% of the total so you have a chance to recover.

sadger commented 10 years ago

About passing reception, I will be adding a new variable for the patient so I can tell if they passed reception or not. For existing patients in the hospital (for compatibility reasons) I have marked everyone as being passed reception who is in the hospital but not in the queues for the reception desks. I think it's a good solution as any. Then only people who have passed reception get evacuated like you suggested. The code is now updated as of commit 77eb4fde64da6f502c5622fa26f3733b9ff1a97c.

The balance reputation loss I still need to look at.

sadger commented 10 years ago

@MarkL1961 you were right about the reputation loss! It was applying it twice so you'd lose over 66% reputation. I've fixed this now in commit 219f8b7. That's the last of the high priority bugs (i'm fixing backwards compatibility now) done I hope. I'll look into some of the smaller ones over the next few days but i'll have to start rebasing for the merge at the end of next week.