search

sadger / CorsixTH

Open source clone of Theme Hospital
Other
1 stars 0 forks source link

Arrow icon showing at wrong time #8

Open MarkL1961 opened 10 years ago

MarkL1961 commented 10 years ago

I think I have found a flaw, I just got an epidemic with two victims and then noticed that one of them had not even been to reception yet. I am guess that it was a fluke she had the same illness and that it was not passed on to her by the first one. With the last two epidemics, again with only single victims I looked at their history and could see that they had been in the hospital a while with GP, Diag room, GP then discovered. The hospital is very busy, so they would have come into contact with others, so it ought to have spread to them. Have you made any changes yet to allow a disease to change if not discovered for that patient? This is the only thing I can think of for the spreading not happening as the chances are pretty slim for two patients to come into close contact and also have the same illness.

Perhaps there should be something where you cannot be part of the epidemic until you have passed reception? There was already a flag for this when I tried to add falling down for patients "self.booked_in = false" that changed to true once they had been to the reception desk. I think I removed it at some point later, but you could always add it again. I planned on adding it back at some point anyway.

MarkL1961 commented 10 years ago

Reply Sorry Mark, I haven't had time to have a good luck/change anything hopefully I will find time soon. It should spread to others even if they are not fully diagnosed because it simply compares diseases. I think what we do need is passing the disease on to other non-visual patients with a different disease but that needs a bit of work.

MarkL1961 commented 10 years ago

a in the attached pic you see there is a second victim on his way to reception. Whilst at reception he shows the icon with the arrow (next for vaccination), but he is not. I think it wrongly shows this icon when they are next to be seen by someone i.e. reception, GP etc. It then changes back to the normal icon. I think the arrow icon is only to do with vaccination to show they are next, with the icon after to be the one with the cross to show they have been vaccinated. In the next pic you can see what I mean, he is waiting for his first GP visit.

b

The second victim did get counted in the fax etc at the end this time.

sadger commented 10 years ago

Oh I think it's the condition for being the vaccination candidate which is the problem. If they are "static" either sitting down or standing still or queuing they are able to become the vaccination candidate. The condition probably just needs tweaking. That patient that has the icon was marked for vaccination right?

MarkL1961 commented 10 years ago

At the time of the second pic I had marked him for vaccination. There is no nurse nearby though.

sadger commented 10 years ago

I'm confused why this is undesired behaviour then, he is infected and marked for vaccination, why shouldn't he be the next candidate? I'm on IRC all day today and working on epidemics if you find time to pop in if you wish to discuss anything :).

MarkL1961 commented 10 years ago

how is he infected if he has not yet seen a GP to know what is wrong and that he is contagious?

His icon changes to the arrow if you have marked him when at reception as he is next in line then changes back to the normal green bug. It does the same as he waits for the GP, it seems to change to the arrow because he is next, not that because the nurse is about to give him the vaccination - it is this I think is wrong. EDIT: Going back to this, the arrow appears when a patient is next in the queue e.g. GP office. The nurse is wandering around and in not even close to this patient. The arrow appears to show when the patient is next, not when they are next to be vaccinated and I think that is the problem. It does also show if they are next to be vaccinated, that is correct. It is not correct to show if they are next in line for another reason like waiting at reception or the GP office and there is no nurse close by.

sadger commented 10 years ago

You don't need to see the GP to know he is contagious, if the epidemic is active then if someone gets infected they are automatically contagious, or you think it should be a diagnostic thing? The problem with this is people can only become contagious after the player knows about the epidemic so background infections wouldn't work and you'd only have one infected player when the epidemic is revealed assuming we do not distinguish between infected and actively contagious.

Assume 10 patients get infected out of 20 that have the disease. When the epidemic is discovered (one fully diagnosed) which patients do we make visually contagious to the player, they may have all seen a GP before the epidemic was discovered. One solution as a compromise is to just make sure they have visited the GP at least once before being visually contagious, this however makes the epidemic harder as you don't know who is contagious and they can still spread the disease.

MarkL1961 commented 10 years ago

I think the answer is that you can only become infected from the initial carrier once you have passed through reception. I am also wondering about this pool of epidemics. If the second person had not been created with the same epidemic he or she would not have been added to the same one. Now that the spreading is working correctly and it spreads pretty quickly I don't think you need to have a pool in the background or it could become a case of one epidemic straight after another. I did see this today loading an old save where there was a pool and the next epidemic was starting before the health minister had arrived for the last one. If it becomes too hard, I think it will become hated and spoil the game play.

MarkL1961 commented 10 years ago

I have changed the title for this one. Thinking about my earlier comments and patients can be infected on the way in and passing through reception. This just leaves the thing with the arrow, which will show when someone is in a queue and there is no nurse nearby. Perhaps it is the nurse that is triggering this and then changing her mind! It though does look as though it is being in a queue and being next that can trigger it too.

sadger commented 10 years ago

Yeah I noticed the arrow for being next shows at the wrong time. I'll look into it I'll have to fix this for release

sadger commented 10 years ago

I've tried to fix this now as of commit 6332752 if the nurse is interrupted, the patient moves or the nurses moves etc. It will deselect that patient as a vaccination candidate and the icon should go. Let me know if it still occurs after updating. It may happen still very rarely when you interrupt it just before it vaccinates or something but for the most part it shouldn't happen.