sadiqrazasyed / wallpaperboard-enhanced

Android Json based wallpaper dashboard library
38 stars 23 forks source link

Test Key Notifications Issues #15

Closed yasanglass closed 5 years ago

yasanglass commented 5 years ago

there is no new commit about notification ads or anything from you, have you silently added that feature or something? i dont want to use notification ads in my app because obviously users hate it.

yasanglass commented 5 years ago

in build.gradle there is a new code that links the project to onesignal. so yeah basically if no one notices to change it we get ads from you. nice.

defaultConfig { manifestPlaceholders = [manifestApplicationId: "${applicationId}", onesignal_app_id: "068baede-1a04-432c-b8c4-6fc59bc84500", onesignal_google_project_number: "745634907655"] }

sadiqrazasyed commented 5 years ago

I was testing the library in my desktop with notification ADS. Why are you still using the key provided in the sample project? Please generate a key for your app itself. Sample key is for testing purposes only.

Edit: I'm basically working on fixing the library and making it compatible with AS 3.2.0 with banner ADS as well. So there will be furthermore testings in future. I suggest you change the key.

yasanglass commented 5 years ago

i just removed changed the strings to empty strings. it should work right? im now trying to build my apps on AS 3.0. still getting some errors tho.

sadiqrazasyed commented 5 years ago

Don't keep it empty as that will result in compiling issues. This was the reason why I generated a dummy key. Follow the steps I've written in README on how to get a key for yourself. Regarding the errors, I'll give you a quick fix soon till I update the library itself.

yasanglass commented 5 years ago

ive done that now but im still getting this: (sample app)

Error:FAILURE: Build failed with an exception.

BUILD FAILED in 3s

Amitind commented 5 years ago

Just Wanted to let you know Although I have replaced the app id and key in my app, but still few users reported that they got notification ads few days ago.

Aksx73 commented 5 years ago

I was testing the library in my desktop with notification ADS. Why are you still using the key provided in the sample project? Please generate a key for your app itself. Sample key is for testing purposes only.

Edit: I'm basically working on fixing the library and making it compatible with AS 3.2.0 with banner ADS as well. So there will be furthermore testings in future. I suggest you change the key.

Yeah waiting for that.