search

sadko4u / tamgamp.lv2

Tamgamp (Rhymes with: "Damage Amp") is LV2 guitar amp simulator
GNU Lesser General Public License v3.0
42 stars 5 forks source link

README improvements #3

Closed cyrusadkisson closed 4 years ago

cyrusadkisson commented 4 years ago
  1. The README doesn't really state how tamgamp is any different than guitarix. IMO, what you wrote on the linuxmusicians forum announcement...
The key features of this project according to technical requirements were:
Simplicity of the interface, no UI (use generic one), minimum knobs/sliders
Smooth bypass button.
Smooth switch between amplifier models.
Smooth switch between tone control chains.
Smooth knob control without pops and other sound artifacts which allows to apply automation to the plugin.
Normalized output level: different amplifiers should sound almost of the same output loudness with different gain settings.

... should be front and center at the top of the README as well.

  1. The README should also state that tamgamp does not attempt to do any cab simulation and that the user should use their own.

  2. At the top of the README, I would include a picture of it in action. Like this https://imgur.com/a/rR5HJOR

  3. It's not pronounced "damage amp", it rhymes with "damage amp".

sadko4u commented 4 years ago

Consider looking this: https://github.com/sadko4u/tamgamp.lv2/blob/github-issue-3/README.md

All is OK now?

cyrusadkisson commented 4 years ago

Not quite:

  1. The font in the image is hard to read.
  2. You haven't selected an amp chain in the image
  3. "Preamplifier simulation only, no cabinet/power amplifier simulation is required." sounds like (and was) a product requirement. When talking to the user, it should be more like "Preamplifier simulation only, for simplicity and flexibility. (Use a separate cab simulator.)"
  4. This entire block:

Smooth bypass button. Smooth switch between amplifier models. Smooth switch between tone control chains. Smooth knob control without pops and other sound artifacts which allows to apply automation to the plugin.

can be reduced to

"Smooth bypass/automation. No pops, spikes or clicks."

sadko4u commented 4 years ago

Updated screenshot and README. Please verify.

cyrusadkisson commented 4 years ago

Looks good!

sadko4u commented 4 years ago

Merged changes into master