Added METADATA_BASE and NEXTJS_RUNTIME as environment variables

sadmann7 / skateshop

An open source e-commerce skateshop build with everything new in Next.js.

https://skateshop.sadmn.com

MIT License

5.18k stars 743 forks source link

Closed ala-garbaa-pro closed 1 year ago

ala-garbaa-pro commented 1 year ago

I've added two environment variables:

METADATA_BASE and NEXTJS_RUNTIME. You can find more information about METADATA_BASE in the official Next.js documentation at: https://nextjs.org/docs/app/api-reference/functions/generate-metadata
NEXTJS_RUNTIME allows for easy switching between Node.js and Edge.js based on the environment variable.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
skateshop	🔄 Building (Inspect)			Jun 28, 2023 4:55pm

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @sadmann7 on Vercel.

@sadmann7 first needs to authorize it.

sadmann7 commented 1 year ago

Great stuffs man. If you could resolve the merge conflict, i would merge.

ala-garbaa-pro commented 1 year ago

Great stuffs man. If you could resolve the merge conflict, i would merge.

I have successfully resolved the conflict in the merge, please verify if the application is functioning correctly.

sadmann7 commented 1 year ago

Can we now just use the NEXT_PUBLIC_APP_URL for the metadata base?

sadmann7 commented 1 year ago

Can't really merge it. Still showing merge conflicts.

Can you please look into it. Looking forward to merging it

ala-garbaa-pro commented 1 year ago

I will close this PR and open new one