search

sadmann7 / skateshop

An open source e-commerce skateshop build with everything new in Next.js.
https://skateshop.sadmn.com
MIT License
5.18k stars 743 forks source link

Add Loading Spinner for Server Component Pages #14

Closed tarunfy closed 9 months ago

tarunfy commented 1 year ago

Currently, when navigating to pages with server components, there is no loading state displayed to the user. This results in a blank screen until the server data is fetched, leading to a poor user experience. To improve this, we should implement a loading spinner for each server component page where data retrieval takes some time.

PS: It would be great if you could assign me this task. I am willing to contribute to this amazing project. Thanks.

sadmann7 commented 1 year ago

That will be very cool. I am using skeletons for these.

You can use one of the loading pages as reference. https://github.com/sadmann7/skateshop/blob/main/src/app/(lobby)/product/%5BproductId%5D/loading.tsx

tarunfy commented 1 year ago

Do you want me to use skeletons for loading or a normal spinner, because imo on pages like home, we should go with a minimal spinner?

sadmann7 commented 1 year ago

Skeleton looks cooler imo. And layout doesn't shift so much. And user have the prospective how things are laid out

chandra1899 commented 1 year ago

is this issue still open , can i work on this.

sadmann7 commented 1 year ago

Yes go for it

chandra1899 commented 1 year ago

hey, i don't see any blank screen and user experience is also good , can u share a short video to encounter the issue.

agamswaroop619 commented 1 year ago

Yes go for it

Is this still open? Can I put a loading.js in it?