logstash ports on kibana role are FIXED and not using group_vars/all.yml

sadsfae / ansible-elk

:bar_chart: Ansible playbook for setting up an ELK/EFK stack and clients.

https://hobo.house/2016/04/08/automate-elk-stack-and-clients-with-ansible/

Apache License 2.0

337 stars 192 forks source link

logstash ports on kibana role are FIXED and not using group_vars/all.yml #57

Closed acomisario closed 7 years ago

acomisario commented 7 years ago

yes, file install/roles/kibana/tasks/main.yml

uses port 5000 and 5044 istead of using

logstash_syslog_port logstash_localsyslog_port

from group_vars/all.yml

knechtionscoding commented 7 years ago

@acomisario I just fixed that for you.

acomisario commented 7 years ago

Thank you! question, how can i contribute ? doing pull requests does work ? i mean ... do they get reviewed ? bes.t

knechtionscoding commented 7 years ago

@acomisario Yes. @sadsfae is out of the country right now so he hasn't had a chance to review any right now. Feel free to contribute through pull requests. If you have questions let me know and I'll do my best to answer them.

sadsfae commented 7 years ago

@KnechtionsCoding @acomisario thanks for filing this, I'm back from some extensive traveling now. One thing I want to do is rebase the firewall stuff into it's own optional role.

Reviewing the PR for this now.

sadsfae commented 7 years ago

This is resolved now.