saeaadl / emv2

AADL Error Model V2 annex language
0 stars 0 forks source link

Inconsistent rules for error_detection_effect #49

Open joeseibel opened 4 years ago

joeseibel commented 4 years ago

In section E.10, the syntax allows an error_detection_effect to refer to a port in a feature group or nested feature groups:

error_detection ::=
  [ defining_error_detection_identifier : ]
  ( error_source_state | all )
    -[ [ error_condition ] ]-> 
    error_detection_effect ;

error_detection_effect ::=
    ( outgoing_port_reference | internal_event_reference ) ! 
    [ ( error_code_value ) ]

outgoing_port_reference ::=
    { featuregroup_identifier . }* port_identifier

However, the naming rule N5 does not allow ports in feature groups as it states, "The port identifier in a detection event must exist in the namespace of the component containing the component error behavior specification."

See https://github.com/osate/osate2/issues/2128

joeseibel commented 4 years ago

I am proposing to replace N5 with, "The first identifier of an outgoing_port_reference must exist in the namespace of the component containing the component error behavior specification."

jjhugues commented 4 years ago

Implemented and tagged as "Issue #44" in document AS5506_5-20200615.docx => should have been #49