search

saebekassebil / teoria

Javascript taught Music Theory
http://saebekassebil.github.io/teoria
MIT License
1.31k stars 114 forks source link

Scale.get #113

Closed jaylupus closed 7 years ago

jaylupus commented 7 years ago

Extended 'Scale.get' function to get notes outside of octave range. Added tests.

saebekassebil commented 7 years ago

Very cool! I'll just have to check the tests when I get home to my computer.

Thank you for you contribution jaylupus (:

saebekassebil commented 7 years ago

I'm not sure how the negative numbers should work. As of now I get a RangeError infinite-loop when trying to get scale.get(0), scale.get(-7), scale.get(-14), etc

Also it seems a bit counter-intuitive that scale.get(-1) isn't just one note down from unison? But I guess we have to keep that way

saebekassebil commented 7 years ago

So I've added the functionality you've implemented. And thanks for that - it was an obvious addition to make to that method :)

Please let me now if it works out for you the way you expect. (and sorry for the late answer)

jaylupus commented 7 years ago

Thank you, I'll do so.

On Sun, Jul 2, 2017 at 8:05 AM, Jakob Miland notifications@github.com wrote:

So I've added the functionality you've implemented. And thanks for that - it was an obvious addition to make to that method :)

Please let me now if it works out for you the way you expect. (and sorry for the late answer)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/saebekassebil/teoria/pull/113#issuecomment-312487918, or mute the thread https://github.com/notifications/unsubscribe-auth/AK1KwRKd3kHbs0ua5LsdOSMoVR78vJJ-ks5sJ4eGgaJpZM4LDbR8 .