search

saebekassebil / teoria

Javascript taught Music Theory
http://saebekassebil.github.io/teoria
MIT License
1.31k stars 114 forks source link

Getting chordType "trichord" instead of "triad" and "unknown" instead of "tetrad" #115

Closed Scriptim closed 7 years ago

Scriptim commented 7 years ago

When I try to get the chordType of a Chord instance, I get following results:

trichord for CM (should be triad) unknown for C7 (should be tetrad)

I have the same problems with similar chords. Is this a bug or my fault?

teoria

saebekassebil commented 7 years ago

Hey @Scriptim ! Sorry for getting back so late, but the late exams have been over me and time has been in shortage.

Anyway: Trichord is (to my knowledge) the more general term of any chord consisting of 3 notes. So Tri-chord for Cm is not per se wrong. But it would indeed be more correct to say triad. Same goes for C7 (which I thought already worked..)

I'll look into it and come back

saebekassebil commented 7 years ago

Hey again - looked into it, and it was a silly mistake in the code barring this from working properly. It should work now, and I've added some tests, but please try it out and let me know if it doesn't!

Thanks for the notice :)

Scriptim commented 7 years ago

It works fine for me, thank you very much. Great project