saebekassebil / teoria

Javascript taught Music Theory
http://saebekassebil.github.io/teoria
MIT License
1.32k stars 114 forks source link

Refactor scale inclusion #30

Closed saebekassebil closed 11 years ago

saebekassebil commented 11 years ago

I've rewritten the way scales get included. They can now be included/excluded in a more expressive way, that lets the user decide which scales to include and which to exclude.

A number of scales are included by default:

The syntax for configuring the build is simple:

$ jake build scales=-aeolian,-chromatic

results in a build without the aeolian and chromatic, while:

$ jake build scales=-locrian,+bebop

results in a build without the locrian, but with the (non-standard) bebop scale.

I'd like to hear if this solves the issue discussed in #24 - I personally like it, and I think we can now start adding other scales to this repository, such as the bebop, the harmonic and melodic minor, and many other interesting scales without necessarily bloating the final build!

CC'ing @ohmycode, @quickredfox and @gregjopa as you seem like the most interested guys :)

saebekassebil commented 11 years ago

Well, I'm just going to land this, since it doesn't really effect the users of the library in any way. Let me know if I'm wrong about this.

quickredfox commented 11 years ago

Didn't take/have time to test but I agree with your last comment/action.