search

saebekassebil / teoria

Javascript taught Music Theory
http://saebekassebil.github.io/teoria
MIT License
1.32k stars 114 forks source link

TeoriaInterval#octaves() is terribly broken #44

Closed saebekassebil closed 10 years ago

saebekassebil commented 10 years ago

Works as expected with ascending intervals, but descending intervals go crazy:

teoria.interval('P-5').octaves() == 0 // Expected
teoria.interval('P-4').octaves() == -2 // wtf
saebekassebil commented 10 years ago

Fixed in 87b5f42052ad67f683c69d516c4932ab6fd432bc

Works as expected:

teoria.interval('P-5').octaves() == 0
teoria.interval('P-4').octaves() == 0
teoria.interval('M-16').octaves() == 2