search

saebekassebil / teoria

Javascript taught Music Theory
http://saebekassebil.github.io/teoria
MIT License
1.32k stars 115 forks source link

Change TeoriaInterval simple() and compound() methods to return a TeoriaInterval #45

Closed seanyeh closed 10 years ago

seanyeh commented 10 years ago

Hey there! I changed simple() and compound() to return TeoriaInterval objects. A few other places in the library still expected them to return strings as they used to, so I just added toString() to them. Also, I've basically swapped the contents of compound() and toString() Let me know what you think :)

saebekassebil commented 10 years ago

Cheers Sean!

Looks good, with comments addressed. Do you have time to write some test for this new behaviour, or should I just do it?

seanyeh commented 10 years ago

I could work on it later today :)

saebekassebil commented 10 years ago

Thanks, I've just found some unexpected behaviour in the #octaves() function, which I'm working on.

seanyeh commented 10 years ago

Okay, I updated the README and added tests using the TeoriaInterval.equal function :)

saebekassebil commented 10 years ago

Since this is breaking changes, I've landed it as version 0.4 along with some small changes I had. Thanks again Sean!