search

saebekassebil / teoria

Javascript taught Music Theory
http://saebekassebil.github.io/teoria
MIT License
1.32k stars 114 forks source link

Perfect octave and large intervals #50

Closed amitgur closed 10 years ago

amitgur commented 10 years ago

Hey there @saebekassebil

I'm missing something with perfect octaves

note("c4").inverval("P8") .. the result should be c5 but I'm geting c4.

I also need bigger intervas in my app:

note("c4").interval("P-16") should be c2 note ("d4").interval("M-17") should be c2

any ideas ?

amitgur commented 10 years ago

Found the answer c4.interval(P15) = c6 in music intervals 8 + 8 = 15. this was my mistake

saebekassebil commented 10 years ago

Hey @amitgur, I think that large intervals should already be implemented, teoria.note("c4").interval("P8") is c5 when I test, and as you noticed: A double octave is P15 no P16 (which is invalid).

Closing as invalid