Closed dstaubsauger closed 10 years ago
Hi @dstaubsauger and thank you for checking out this library! The reason for the messy diff is just your whitespace indentation. In teoria we only use spaces and indent by 2 spaces per level.
Regarding the functionality, teoria can already parse power chords (A5
, G#5
, etc.). I've never seen no3
nor no5
before - can you point me to an example where that is used?
I don't think that susb2
or sus#4
are real chords. They're more like a collection of notes in that they don't have any relationship between them.
@dstaubsauger I'm closing this for now, as I don't see any use in these chords. You're very welcome, anytime, to share any ideas or code you think is suitable for the teoria project :)
Hi, i added support for chords for susb2, sus#4, no3, no5 in the chord parser, and tests. Sorry the diff is such a mess, this is my first time making a pull request. Thanks for the great library! dstaubsauger