Getting the midi value of a note

saebekassebil / teoria

Javascript taught Music Theory

http://saebekassebil.github.io/teoria

MIT License

1.32k stars 114 forks source link

Getting the midi value of a note #63

Closed matthewconstantine closed 9 years ago

matthewconstantine commented 9 years ago

How about a toMIDI to compliment fromMIDI?

saebekassebil commented 9 years ago

Actually we've already had this suggested before - and I said "no more sugar to this library" (issue #51). But until this library gets refactored into smaller modules - screw it. Let's do it!

Could you call it .midi() and add the documentation next to note.key()? That'd be perfect.

Thank you Matt!

matthewconstantine commented 9 years ago

Cool. I made the changes. Does that look good?

saebekassebil commented 9 years ago

I believe you've forgot to change the actual method's name?

saebekassebil commented 9 years ago

Took the liberty of fixing that last bit myself - Cheers anyway Matt!

matthewconstantine commented 9 years ago

Good catch :) Thanks for the merge!