saebekassebil / teoria

Javascript taught Music Theory
http://saebekassebil.github.io/teoria
MIT License
1.32k stars 114 forks source link

Added build files and changed not to ignore build files #64

Closed panarch closed 9 years ago

panarch commented 9 years ago

Currently, this project does not contain build files.

It is not a problem for users who install teoria using npm, but it is inconvenient for others (bower, global, etc) because users should build manually.

How do you think about containing build files as a default?

Anyway, I have being used teoria very well. It's really nice, thanks!

saebekassebil commented 9 years ago

Hey Taehoon!

We've prepackaged the built files before, but I decided against since it adds another layer of complexity to the pull request/bug-fixing procedure. I kept forgetting to bump the concatenated files which resulted in a mess.

Anyone can just install with npm and copy the file if that's their setup. Seems easier to do npm install teoria && mv node_modules/teoria/dist/teoria.js ./to/my/path than cloning a git repository.

Anyways thank you very much for your interest! I'm glad that you're happy about teoria! Please let me know if you run into some kind of problem or lack of a feature. And if this building stuff is a really big problem - well, then I'll look into it.

Cheers