Correct Helmholtz notation

saebekassebil / teoria

Javascript taught Music Theory

http://saebekassebil.github.io/teoria

MIT License

1.32k stars 114 forks source link

Correct Helmholtz notation #8

Closed saebekassebil closed 12 years ago

saebekassebil commented 12 years ago

The implementation of the Helmholtz notation is pt. erroneous. Helmholtz notation does not prefix commas with octaves lower than the great octave (contra octave, subcontra octave, etc). The commas are suffixed, though the note name is still uppercase.

// Expected to throw:
teoria.note(',C') === teoria.note('C1'); 

// Actual result
true

saebekassebil commented 12 years ago

Fixed by above commit 8c03bd7