search

saebekassebil / teoria

Javascript taught Music Theory
http://saebekassebil.github.io/teoria
MIT License
1.32k stars 114 forks source link

Adding method TeoriaChord.inverted() #81

Closed gsouf closed 4 years ago

gsouf commented 9 years ago

ping @saebekassebil

saebekassebil commented 9 years ago

Hey @gsouf !

I'm sorry about the long response time on this - thank you for taking the time for doing this!

I was just thinking that it might be more beneficial to have a method for deciding which inversion the current chord is in?

Example: Take an A-mol (minor). A, C, E. It would be nice if I could then do something like:

var am = teoria.chord('Am');
am.inversion() == 0;

am.voicing(['M3', 'P5', 'P8']).inversion() === 1

am.voicing(['P5', 'P8', 'M10']).inversion() === 2

am.voicing(['P1', 'P5']).inversion() === null

Does that make sense?

gsouf commented 9 years ago

Ofcourse its a very good idea, make it soon Le 9 juil. 2015 15:14, "Jakob Miland" notifications@github.com a écrit :

Hey @gsouf https://github.com/gsouf !

I'm sorry about the long response time on this - thank you for taking the time for doing this!

I was just thinking that it might be more beneficial to have a method for deciding which inversion the current chord is in?

Example: Take an A-mol (minor). A, C, E. It would be nice if I could then do something like:

var am = teoria.chord('Am'); am.inversion() == 0;

am.voicing(['M3', 'P5', 'P8']).inversion() === 1

am.voicing(['P5', 'P8', 'M10']).inversion() === 2

am.voicing(['P1', 'P5']).inversion() === null

Does that make sense?

— Reply to this email directly or view it on GitHub https://github.com/saebekassebil/teoria/pull/81#issuecomment-119959172.