search

saebekassebil / teoria

Javascript taught Music Theory
http://saebekassebil.github.io/teoria
MIT License
1.31k stars 114 forks source link

Whole tone scale with test #93

Closed garrettmaring closed 8 years ago

saebekassebil commented 8 years ago

First off: Cheers Garrett for contributing to the project - it's always very welcome :)

So, this approach is a bit "awkward" since for example an "A" wholetone scale will be: a, b, c#, d#, e#, fx instead of a, b, c#, d#, f, g. But since the whole tone scale is not a diatonic scale, this is only to be expected since we handle scales the way we do.

I'll accept it, but I guess to make it more useful you should simplify the notes afterwards:

var t = require('teoria');
var simplify = require('teoria-simplify-note');

var awhole = t.note('a').scale('wholetone').notes().map(simplify); // a, b, c#, d#, f, g
garrettmaring commented 8 years ago

Thanks! Awesome project, glad to contribute. Agreed with the issues of correctly notated whole-tone scales. So should I add simplification to the whole tone scale, or will this be on the user end after creating a new whole tone scale? Still getting acquainted with the library, sorry if I seem a bit lost!