search

saebyn / munkres-cpp

Kuhn-Munkres (Hungarian) Algorithm in C++
http://saebyn.info/2007/05/22/munkres-code-v2/
GNU General Public License v2.0
204 stars 79 forks source link

Extract methods / functions out of the longer steps #4

Closed Gluttton closed 10 years ago

Gluttton commented 10 years ago

Extract methods / functions out of the longer steps.

saebyn commented 10 years ago

I've made some progress on this in 9db4018806a21b826f4045874f2d25372532c612

Gluttton commented 10 years ago

I've made some progress on this in 9db4018 .

It's great! Comments are realy useful.

Some notes.

  1. In my opinion formal parameters of methods minimize_rows and minimize_columns are redundant, because rows and columns are known through variable matrix. Actually those methods could be made with passing matrix through input parameters (it will be better for testing).
  2. It is not importent, but it is seems to me that comments of methods minimize_rows and minimize_columns should have the same structure.
saebyn commented 10 years ago

I agree 7ffbdc4702e9ab9f6c340b77dcbddfd4ba9ada08