Support other matrix data type classes.

saebyn / munkres-cpp

Kuhn-Munkres (Hungarian) Algorithm in C++

http://saebyn.info/2007/05/22/munkres-code-v2/

GNU General Public License v2.0

204 stars 79 forks source link

Support other matrix data type classes. #6

Open Gluttton opened 10 years ago

Gluttton commented 10 years ago

Support other matrix data type classes from other libs (boost)?

UPD Implemented:

std::array (C++11);
raw (C-style) array;
boost::numeric::ublas::matrix;
std::vector <std::vector <double> >.

Gluttton commented 10 years ago

To make Matrix data type generalized, I see two ways:

first: involve abstract data type with pure methods (which will describe interface);
second: Munkres class should become template which will be parameterized by specific Matrix data type.

I would prefer, second way because (in my opinion) that would be better for performance. But first way (in my opinion) would be more graceful.

What do you think about it? Do you have other solutions or ideas?

saebyn commented 10 years ago

Maybe instead, modify Matrix to copy in and out of other implementations' instances?

Gluttton commented 10 years ago

Oh! It seems I misunderstood the ticket's aim! If the aim is extend interface, your solution will enough.

I thought, that you want to try solve assignment problem on different Matrix types (may be to research performance issues)!

saebyn commented 10 years ago

I was aiming mainly to make it easier to use this code from within existing code. I don't think it would hurt to have the Munkres class as a template, additionally.

Gluttton commented 8 years ago

When I see changes which was made according to this issue, I'm not satisfied. There are a lot of classes of matrices: Qt, opencv, Eigen, etc... So it's impossible implement adaptors for all of them. It's require more generic approach. Also existed adapters pollute code.